ich777/ugreen_dx4600_leds_controller
1
0
Fork 0
mirror of https://github.com/miskcoo/ugreen_dx4600_leds_controller.git synced 2025-07-23 12:23:09 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add verbose mode in the kernel driver (#47)
Some checks failed
Build kernel module for TrueNAS / build-and-run (push) Has been cancelled
Details

Browse Source 
- Error messages are displayed only when verbose mode is enabled
This commit is contained in:
Christoph Hummer
2024-12-15 16:17:14 +01:00
committed by GitHub
parent 39511eb639
commit a4d9e2e73e
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
kmod/led-ugreen.c
View File

@@ -24,6 +24,10 @@
#endif #endif
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
static bool verbose = false;
module_param(verbose, bool, 0644);
MODULE_PARM_DESC(verbose, "Enable verbose output");
static struct ugreen_led_state *lcdev_to_ugreen_led_state(struct led_classdev *led_cdev) { static struct ugreen_led_state *lcdev_to_ugreen_led_state(struct led_classdev *led_cdev) {
return container_of(led_cdev, struct ugreen_led_state, cdev); return container_of(led_cdev, struct ugreen_led_state, cdev);
} }
@@ -183,7 +187,7 @@ static void ugreen_led_turn_on_or_off_unlock(struct ugreen_led_array *priv, u8 l
int rc = ugreen_led_change_state_robust(priv->client, led_id, 0x03, on ? 1 : 0, 0, 0, 0); int rc = ugreen_led_change_state_robust(priv->client, led_id, 0x03, on ? 1 : 0, 0, 0, 0);
if (rc == 0) { if (rc == 0) {
priv->state[led_id].status = on ? UGREEN_LED_STATE_ON : UGREEN_LED_STATE_OFF; priv->state[led_id].status = on ? UGREEN_LED_STATE_ON : UGREEN_LED_STATE_OFF;
} else { } else if (verbose) {
pr_err("failed to turn %d %s", led_id, on ? "on" : "off"); pr_err("failed to turn %d %s", led_id, on ? "on" : "off");
} }
} }
@@ -199,7 +203,7 @@ static void ugreen_led_set_brightness_unlock(struct ugreen_led_array *priv, u8 l
int rc = ugreen_led_change_state_robust(priv->client, led_id, 0x01, brightness, 0, 0, 0); int rc = ugreen_led_change_state_robust(priv->client, led_id, 0x01, brightness, 0, 0, 0);
if (rc == 0) { if (rc == 0) {
state->brightness = brightness; state->brightness = brightness;
} else { } else if (verbose) {
pr_err("failed to set brightness of %d to %d", led_id, brightness); pr_err("failed to set brightness of %d to %d", led_id, brightness);
} }
} }
@@ -223,7 +227,7 @@ static void ugreen_led_set_color_unlock(struct ugreen_led_array *priv, u8 led_id
state->r = r; state->r = r;
state->g = g; state->g = g;
state->b = b; state->b = b;
} else { } else if (verbose) {
pr_err("failed to set color of %d to 0x%02x%02x%02x", led_id, r, g, b); pr_err("failed to set color of %d to 0x%02x%02x%02x", led_id, r, g, b);
} }
} }
@@ -247,7 +251,7 @@ static void ugreen_led_set_blink_or_breath_unlock(struct ugreen_led_array *priv,
state->t_on = t_on; state->t_on = t_on;
state->t_cycle = t_cycle; state->t_cycle = t_cycle;
state->status = led_status; state->status = led_status;
} else { } else if (verbose) {
pr_err("failed to set %s of %d to %d %d", is_blink ? "blink" : "breath", led_id, t_on, t_cycle); pr_err("failed to set %s of %d to %d %d", is_blink ? "blink" : "breath", led_id, t_on, t_cycle);
} }
} }