36 Commits

Author SHA1 Message Date
xaizek
8d7e74db1b Fix a typo in start_fan_cfg_update()
This fixes commit 563bade4b0 ("Proper management of
configuration mode") from #121 which has invalid condition in one of the
for loops.

Fixes #131
2025-06-29 21:34:35 +03:00
xaizek
563bade4b0 Proper management of configuration mode
Instead of sleeping for 50 milliseconds and hoping that the EC is in
expected state, poll EC's status register to know whether it has entered
or left configuration mode.
2025-04-25 21:08:46 +03:00
Frederic BOLTZ
ec431bf2ce Update nct6687.c
Keep backward compatibility with prévious kernet.

Could you try on 6.11?
2024-09-02 16:02:07 +02:00
Gwenhael Le Moine
66c35797a5 fix compilation with kernel 6.11.0-rc6 2024-09-02 13:35:20 +02:00
Tomasz Moń
3e7e79c3f3 [RFC] Update cached pwm values on pwm store
Userspace application fan2go expects written pwm value to be returned on
read after 5 ms. If the value read back then fan2go assumes that the pwm
is resolution limited and was clamped by the driver.

The nct6687d driver returns cached pwm values on reads. The cache is
updated at most once per second (unless resumed from suspend) and
therefore it leads for fan2go to falsely analyzing the pwm output as
resolution limited.

Avoid the issue by waiting for pwm value to be reported back on each
write and updating the cache immediately. On MSI PRO Z790-P WIFI
(MS-7E06) it takes around 500 ms for the pwm value (with DC mode fan
connected, so it is not a real PWM but a voltage) to be read back after
write.

Signed-off-by: Tomasz Moń <desowin@gmail.com>
2024-02-22 18:51:51 +01:00
SergeyMy
1c0b17a90f Update nct6687.c
:)
2024-02-04 02:46:18 +05:00
SergeyMy
07c1b5a166 fixed mode to enable
fixed
https://github.com/Fred78290/nct6687d/pull/87
2024-02-03 08:43:50 +05:00
xaizek
735c472f76 Add pwm[1-8]_enable to sysfs
They can be used to switch manual vs. firmware-configured fan mode.
2024-01-28 00:47:45 +02:00
xaizek
3937b12170 Fix restoring automatic fan mode on module unload
nct6687_restore_fan_control() could only restore manual fan control, but
not the automatic one due to the way it applied previous state of the
bit.
2024-01-28 00:23:05 +02:00
SergeyMy
b1d0fe89df Update nct6687.c 2023-11-28 20:45:02 +05:00
SergeyMy
20574d2335 it works on nct6683 too
https://github.com/Fred78290/nct6687d/issues/82
2023-11-28 20:27:08 +05:00
SergeyMy
95d5c7b318 add mutex io
must be atomic, otherwise unintended consequences
2023-11-23 20:55:14 +05:00
SergeyMy
44037baa94 Update nct6687.c 2023-10-29 09:13:21 +05:00
SergeyMy
be4509e2db backport kernel-6.6-rc7
Signed-off-by: SergeyMy <virtual@ufasp.ru>
2023-10-27 20:07:49 +05:00
fboltz
3e349808fb FIX: Use the same enum for chipset NCT6686 and NCT6686D 2023-01-22 11:27:11 +01:00
Florian Dollinger
3f7a00e78e 6686D is d441, confimed on MB997 from iBase 2023-01-20 16:26:23 +01:00
Florian Dollinger
c38e309bd2 Adding 6686d
As done here: https://lore.kernel.org/all/20210303065853.1894677-1-lijq9@lenovo.com/
2023-01-18 22:55:18 +01:00
fboltz
4cbfe8084d FEAT: Add manual configuration support 2022-07-17 11:48:26 +02:00
fboltz
6f3f918b8e FIX: Remove duplicate code 2022-07-17 11:17:33 +02:00
fboltz
070cbd2549 FIX: Wrong multiplier 2022-07-17 11:16:58 +02:00
fboltz
0a4cc95fba FEAT: add declared extras register from LibHardwareMonitorLib 2022-07-17 11:15:58 +02:00
fboltz
b826f33828 TYPO: Wrong comment 2022-07-17 11:14:00 +02:00
Martin Pärtel
626d053fa7 Device and chip names for nct6683 2022-06-07 07:17:01 +03:00
Martin Pärtel
0d12bf1a22 Fixed option "force" 2022-06-02 21:55:43 +03:00
Martin Pärtel
93064a7569 Accept NCT6683D (0xc732)
Found on ASRock Taichi B550.
Fan control works with this driver, but not with the in-tree driver.
2022-06-02 21:54:45 +03:00
hzy
81346374ae Disable DEBUG defaultly 2022-03-06 23:41:25 +08:00
fboltz
0bf1d2efbd Add suport for NCT6687D with ID 0xD592 found on MSI B460M bazooka 2022-02-15 23:09:00 +01:00
fboltz
372c6c6154 FEAT: Add debug trace 2020-12-23 08:16:56 +01:00
fboltz
6035991f00 FIX: Issue #2
Not all fans are updated
2020-12-23 08:10:10 +01:00
fboltz
b7a988d059 FIX: Remove DEBUG trace 2020-11-09 21:03:52 +01:00
fboltz
17236eaa13 FEAT: Add voltage support and min max values for temp & fan 2020-11-08 17:23:29 +01:00
fboltz
5480e81e06 FEAT: Display fans label 2020-11-08 01:18:35 +01:00
fboltz
864dbfe7d0 Typo, rename in to voltage 2020-11-08 01:18:05 +01:00
fboltz
f11d1af18a Typo 2020-11-08 01:16:04 +01:00
fboltz
2f02917c55 Remove unused 2020-11-08 01:15:45 +01:00
fboltz
d5ec6adbe4 Add sources 2020-11-08 00:19:03 +01:00