mirror of
https://github.com/tbsdtv/linux_media.git
synced 2025-07-23 04:33:26 +02:00
f9010dbdce
When switching from kthreads to vhost_tasks two bugs were added:
1. The vhost worker tasks's now show up as processes so scripts doing
ps or ps a would not incorrectly detect the vhost task as another
process. 2. kthreads disabled freeze by setting PF_NOFREEZE, but
vhost tasks's didn't disable or add support for them.
To fix both bugs, this switches the vhost task to be thread in the
process that does the VHOST_SET_OWNER ioctl, and has vhost_worker call
get_signal to support SIGKILL/SIGSTOP and freeze signals. Note that
SIGKILL/STOP support is required because CLONE_THREAD requires
CLONE_SIGHAND which requires those 2 signals to be supported.
This is a modified version of the patch written by Mike Christie
<michael.christie@oracle.com> which was a modified version of patch
originally written by Linus.
Much of what depended upon PF_IO_WORKER now depends on PF_USER_WORKER.
Including ignoring signals, setting up the register state, and having
get_signal return instead of calling do_group_exit.
Tidied up the vhost_task abstraction so that the definition of
vhost_task only needs to be visible inside of vhost_task.c. Making
it easier to review the code and tell what needs to be done where.
As part of this the main loop has been moved from vhost_worker into
vhost_task_fn. vhost_worker now returns true if work was done.
The main loop has been updated to call get_signal which handles
SIGSTOP, freezing, and collects the message that tells the thread to
exit as part of process exit. This collection clears
__fatal_signal_pending. This collection is not guaranteed to
clear signal_pending() so clear that explicitly so the schedule()
sleeps.
For now the vhost thread continues to exist and run work until the
last file descriptor is closed and the release function is called as
part of freeing struct file. To avoid hangs in the coredump
rendezvous and when killing threads in a multi-threaded exec. The
coredump code and de_thread have been modified to ignore vhost threads.
Remvoing the special case for exec appears to require teaching
vhost_dev_flush how to directly complete transactions in case
the vhost thread is no longer running.
Removing the special case for coredump rendezvous requires either the
above fix needed for exec or moving the coredump rendezvous into
get_signal.
Fixes: 6e890c5d50 ("vhost: use vhost_tasks for worker threads")
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Co-developed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
84 lines
2.4 KiB
C
84 lines
2.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __X86_KERNEL_FPU_CONTEXT_H
|
|
#define __X86_KERNEL_FPU_CONTEXT_H
|
|
|
|
#include <asm/fpu/xstate.h>
|
|
#include <asm/trace/fpu.h>
|
|
|
|
/* Functions related to FPU context tracking */
|
|
|
|
/*
|
|
* The in-register FPU state for an FPU context on a CPU is assumed to be
|
|
* valid if the fpu->last_cpu matches the CPU, and the fpu_fpregs_owner_ctx
|
|
* matches the FPU.
|
|
*
|
|
* If the FPU register state is valid, the kernel can skip restoring the
|
|
* FPU state from memory.
|
|
*
|
|
* Any code that clobbers the FPU registers or updates the in-memory
|
|
* FPU state for a task MUST let the rest of the kernel know that the
|
|
* FPU registers are no longer valid for this task.
|
|
*
|
|
* Either one of these invalidation functions is enough. Invalidate
|
|
* a resource you control: CPU if using the CPU for something else
|
|
* (with preemption disabled), FPU for the current task, or a task that
|
|
* is prevented from running by the current task.
|
|
*/
|
|
static inline void __cpu_invalidate_fpregs_state(void)
|
|
{
|
|
__this_cpu_write(fpu_fpregs_owner_ctx, NULL);
|
|
}
|
|
|
|
static inline void __fpu_invalidate_fpregs_state(struct fpu *fpu)
|
|
{
|
|
fpu->last_cpu = -1;
|
|
}
|
|
|
|
static inline int fpregs_state_valid(struct fpu *fpu, unsigned int cpu)
|
|
{
|
|
return fpu == this_cpu_read(fpu_fpregs_owner_ctx) && cpu == fpu->last_cpu;
|
|
}
|
|
|
|
static inline void fpregs_deactivate(struct fpu *fpu)
|
|
{
|
|
__this_cpu_write(fpu_fpregs_owner_ctx, NULL);
|
|
trace_x86_fpu_regs_deactivated(fpu);
|
|
}
|
|
|
|
static inline void fpregs_activate(struct fpu *fpu)
|
|
{
|
|
__this_cpu_write(fpu_fpregs_owner_ctx, fpu);
|
|
trace_x86_fpu_regs_activated(fpu);
|
|
}
|
|
|
|
/* Internal helper for switch_fpu_return() and signal frame setup */
|
|
static inline void fpregs_restore_userregs(void)
|
|
{
|
|
struct fpu *fpu = ¤t->thread.fpu;
|
|
int cpu = smp_processor_id();
|
|
|
|
if (WARN_ON_ONCE(current->flags & (PF_KTHREAD | PF_USER_WORKER)))
|
|
return;
|
|
|
|
if (!fpregs_state_valid(fpu, cpu)) {
|
|
/*
|
|
* This restores _all_ xstate which has not been
|
|
* established yet.
|
|
*
|
|
* If PKRU is enabled, then the PKRU value is already
|
|
* correct because it was either set in switch_to() or in
|
|
* flush_thread(). So it is excluded because it might be
|
|
* not up to date in current->thread.fpu.xsave state.
|
|
*
|
|
* XFD state is handled in restore_fpregs_from_fpstate().
|
|
*/
|
|
restore_fpregs_from_fpstate(fpu->fpstate, XFEATURE_MASK_FPSTATE);
|
|
|
|
fpregs_activate(fpu);
|
|
fpu->last_cpu = cpu;
|
|
}
|
|
clear_thread_flag(TIF_NEED_FPU_LOAD);
|
|
}
|
|
|
|
#endif
|