mirror of
https://github.com/tbsdtv/linux_media.git
synced 2025-07-23 20:51:03 +02:00
qed: Improve the stack space of filter_config()
As it was reported and discussed in: https://lore.kernel.org/lkml/CAHk-=whF9F89vsfH8E9TGc0tZA-yhzi2Di8wOtquNB5vRkFX5w@mail.gmail.com/ This patch improves the stack space of qede_config_rx_mode() by splitting filter_config() to 3 functions and removing the union qed_filter_type_params. Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Ariel Elior <aelior@marvell.com> Signed-off-by: Shai Malin <smalin@marvell.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
626bf91a29
commit
f55e36d5ab
@@ -145,12 +145,6 @@ struct qed_filter_mcast_params {
|
||||
unsigned char mac[64][ETH_ALEN];
|
||||
};
|
||||
|
||||
union qed_filter_type_params {
|
||||
enum qed_filter_rx_mode_type accept_flags;
|
||||
struct qed_filter_ucast_params ucast;
|
||||
struct qed_filter_mcast_params mcast;
|
||||
};
|
||||
|
||||
enum qed_filter_type {
|
||||
QED_FILTER_TYPE_UCAST,
|
||||
QED_FILTER_TYPE_MCAST,
|
||||
@@ -158,11 +152,6 @@ enum qed_filter_type {
|
||||
QED_MAX_FILTER_TYPES,
|
||||
};
|
||||
|
||||
struct qed_filter_params {
|
||||
enum qed_filter_type type;
|
||||
union qed_filter_type_params filter;
|
||||
};
|
||||
|
||||
struct qed_tunn_params {
|
||||
u16 vxlan_port;
|
||||
u8 update_vxlan_port;
|
||||
@@ -314,8 +303,14 @@ struct qed_eth_ops {
|
||||
|
||||
int (*q_tx_stop)(struct qed_dev *cdev, u8 rss_id, void *handle);
|
||||
|
||||
int (*filter_config)(struct qed_dev *cdev,
|
||||
struct qed_filter_params *params);
|
||||
int (*filter_config_rx_mode)(struct qed_dev *cdev,
|
||||
enum qed_filter_rx_mode_type type);
|
||||
|
||||
int (*filter_config_ucast)(struct qed_dev *cdev,
|
||||
struct qed_filter_ucast_params *params);
|
||||
|
||||
int (*filter_config_mcast)(struct qed_dev *cdev,
|
||||
struct qed_filter_mcast_params *params);
|
||||
|
||||
int (*fastpath_stop)(struct qed_dev *cdev);
|
||||
|
||||
|
Reference in New Issue
Block a user