mm/z3fold: minor clean up for z3fold_free

Use put_z3fold_header() to pair with get_z3fold_header.  Also fix the
wrong comments.  Minor readability improvement.

Link: https://lkml.kernel.org/r/20220308134311.59086-4-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Miaohe Lin
2022-04-28 23:16:05 -07:00
committed by akpm
parent 78da57d401
commit ed0e5dcab3

View File

@@ -1187,9 +1187,9 @@ headless:
* @handle: handle associated with the allocation returned by z3fold_alloc() * @handle: handle associated with the allocation returned by z3fold_alloc()
* *
* In the case that the z3fold page in which the allocation resides is under * In the case that the z3fold page in which the allocation resides is under
* reclaim, as indicated by the PG_reclaim flag being set, this function * reclaim, as indicated by the PAGE_CLAIMED flag being set, this function
* only sets the first|last_chunks to 0. The page is actually freed * only sets the first|middle|last_chunks to 0. The page is actually freed
* once both buddies are evicted (see z3fold_reclaim_page() below). * once all buddies are evicted (see z3fold_reclaim_page() below).
*/ */
static void z3fold_free(struct z3fold_pool *pool, unsigned long handle) static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
{ {
@@ -1247,7 +1247,7 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
} }
if (page_claimed) { if (page_claimed) {
/* the page has not been claimed by us */ /* the page has not been claimed by us */
z3fold_page_unlock(zhdr); put_z3fold_header(zhdr);
return; return;
} }
if (test_and_set_bit(NEEDS_COMPACTING, &page->private)) { if (test_and_set_bit(NEEDS_COMPACTING, &page->private)) {