ich777/linux_media
1
0
Fork 0
mirror of https://github.com/tbsdtv/linux_media.git synced 2025-07-23 20:51:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

net: libwx: fix memory leak in wx_setup_rx_resources

Browse Source 
When wx_alloc_page_pool() failed in wx_setup_rx_resources(), it doesn't
release DMA buffer. Add dma_free_coherent() in the error path to release
the DMA buffer.

Fixes: 850b971110 ("net: libwx: Allocate Rx and Tx resources")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230418065450.2268522-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Zhengchao Shao
2023-04-18 14:54:50 +08:00
committed by Paolo Abeni
parent a5962e0a8b
commit e315e7b83a
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/wangxun/libwx/wx_lib.c
View File

@@ -1798,10 +1798,13 @@ static int wx_setup_rx_resources(struct wx_ring *rx_ring)
ret = wx_alloc_page_pool(rx_ring); ret = wx_alloc_page_pool(rx_ring);
if (ret < 0) { if (ret < 0) {
dev_err(rx_ring->dev, "Page pool creation failed: %d\n", ret); dev_err(rx_ring->dev, "Page pool creation failed: %d\n", ret);
goto err; goto err_desc;
} }
return 0; return 0;
err_desc:
dma_free_coherent(dev, rx_ring->size, rx_ring->desc, rx_ring->dma);
err: err:
kvfree(rx_ring->rx_buffer_info); kvfree(rx_ring->rx_buffer_info);
rx_ring->rx_buffer_info = NULL; rx_ring->rx_buffer_info = NULL;