mirror of
https://github.com/tbsdtv/linux_media.git
synced 2025-07-23 04:33:26 +02:00
ACPI: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
committed by
Rafael J. Wysocki
parent
49a57857ae
commit
9ec6dbfbdc
@@ -679,7 +679,6 @@ static int __init einj_init(void)
|
||||
{
|
||||
int rc;
|
||||
acpi_status status;
|
||||
struct dentry *fentry;
|
||||
struct apei_exec_context ctx;
|
||||
|
||||
if (acpi_disabled) {
|
||||
@@ -707,25 +706,13 @@ static int __init einj_init(void)
|
||||
|
||||
rc = -ENOMEM;
|
||||
einj_debug_dir = debugfs_create_dir("einj", apei_get_debugfs_dir());
|
||||
if (!einj_debug_dir) {
|
||||
pr_err("Error creating debugfs node.\n");
|
||||
goto err_cleanup;
|
||||
}
|
||||
|
||||
fentry = debugfs_create_file("available_error_type", S_IRUSR,
|
||||
einj_debug_dir, NULL,
|
||||
&available_error_type_fops);
|
||||
if (!fentry)
|
||||
goto err_cleanup;
|
||||
|
||||
fentry = debugfs_create_file("error_type", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, NULL, &error_type_fops);
|
||||
if (!fentry)
|
||||
goto err_cleanup;
|
||||
fentry = debugfs_create_file("error_inject", S_IWUSR,
|
||||
einj_debug_dir, NULL, &error_inject_fops);
|
||||
if (!fentry)
|
||||
goto err_cleanup;
|
||||
debugfs_create_file("available_error_type", S_IRUSR, einj_debug_dir,
|
||||
NULL, &available_error_type_fops);
|
||||
debugfs_create_file("error_type", S_IRUSR | S_IWUSR, einj_debug_dir,
|
||||
NULL, &error_type_fops);
|
||||
debugfs_create_file("error_inject", S_IWUSR, einj_debug_dir,
|
||||
NULL, &error_inject_fops);
|
||||
|
||||
apei_resources_init(&einj_resources);
|
||||
einj_exec_ctx_init(&ctx);
|
||||
@@ -750,66 +737,37 @@ static int __init einj_init(void)
|
||||
rc = -ENOMEM;
|
||||
einj_param = einj_get_parameter_address();
|
||||
if ((param_extension || acpi5) && einj_param) {
|
||||
fentry = debugfs_create_x32("flags", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, &error_flags);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
fentry = debugfs_create_x64("param1", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, &error_param1);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
fentry = debugfs_create_x64("param2", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, &error_param2);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
fentry = debugfs_create_x64("param3", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, &error_param3);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
fentry = debugfs_create_x64("param4", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, &error_param4);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
|
||||
fentry = debugfs_create_x32("notrigger", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, ¬rigger);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
debugfs_create_x32("flags", S_IRUSR | S_IWUSR, einj_debug_dir,
|
||||
&error_flags);
|
||||
debugfs_create_x64("param1", S_IRUSR | S_IWUSR, einj_debug_dir,
|
||||
&error_param1);
|
||||
debugfs_create_x64("param2", S_IRUSR | S_IWUSR, einj_debug_dir,
|
||||
&error_param2);
|
||||
debugfs_create_x64("param3", S_IRUSR | S_IWUSR, einj_debug_dir,
|
||||
&error_param3);
|
||||
debugfs_create_x64("param4", S_IRUSR | S_IWUSR, einj_debug_dir,
|
||||
&error_param4);
|
||||
debugfs_create_x32("notrigger", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, ¬rigger);
|
||||
}
|
||||
|
||||
if (vendor_dev[0]) {
|
||||
vendor_blob.data = vendor_dev;
|
||||
vendor_blob.size = strlen(vendor_dev);
|
||||
fentry = debugfs_create_blob("vendor", S_IRUSR,
|
||||
einj_debug_dir, &vendor_blob);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
fentry = debugfs_create_x32("vendor_flags", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, &vendor_flags);
|
||||
if (!fentry)
|
||||
goto err_unmap;
|
||||
debugfs_create_blob("vendor", S_IRUSR, einj_debug_dir,
|
||||
&vendor_blob);
|
||||
debugfs_create_x32("vendor_flags", S_IRUSR | S_IWUSR,
|
||||
einj_debug_dir, &vendor_flags);
|
||||
}
|
||||
|
||||
pr_info("Error INJection is initialized.\n");
|
||||
|
||||
return 0;
|
||||
|
||||
err_unmap:
|
||||
if (einj_param) {
|
||||
acpi_size size = (acpi5) ?
|
||||
sizeof(struct set_error_type_with_address) :
|
||||
sizeof(struct einj_parameter);
|
||||
|
||||
acpi_os_unmap_iomem(einj_param, size);
|
||||
pr_err("Error creating param extension debugfs nodes.\n");
|
||||
}
|
||||
apei_exec_post_unmap_gars(&ctx);
|
||||
err_release:
|
||||
apei_resources_release(&einj_resources);
|
||||
err_fini:
|
||||
apei_resources_fini(&einj_resources);
|
||||
err_cleanup:
|
||||
pr_err("Error creating primary debugfs nodes.\n");
|
||||
debugfs_remove_recursive(einj_debug_dir);
|
||||
|
||||
return rc;
|
||||
|
Reference in New Issue
Block a user