ich777/linux_media
1
0
Fork 0
mirror of https://github.com/tbsdtv/linux_media.git synced 2025-07-23 12:43:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

binder: change error code from postive to negative in binder_transaction

Browse Source 
Depending on the context, the error return value
here (extra_buffers_size < added_size) should be
negative.

Acked-by: Martijn Coenen <maco@android.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201026110314.135481-1-zhangqilong3@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Zhang Qilong
2020-10-26 19:03:14 +08:00
committed by Greg Kroah-Hartman
parent 6c20032c22
commit 88f6c77927
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/android/binder.c
View File

@@ -3103,7 +3103,7 @@ static void binder_transaction(struct binder_proc *proc,
if (extra_buffers_size < added_size) { if (extra_buffers_size < added_size) {
/* integer overflow of extra_buffers_size */ /* integer overflow of extra_buffers_size */
return_error = BR_FAILED_REPLY; return_error = BR_FAILED_REPLY;
return_error_param = EINVAL; return_error_param = -EINVAL;
return_error_line = __LINE__; return_error_line = __LINE__;
goto err_bad_extra_size; goto err_bad_extra_size;
} }