mirror of
https://github.com/tbsdtv/linux_media.git
synced 2025-07-23 04:33:26 +02:00
vfs: Use IOP_XATTR flag for bad-inode handling
With this change, all the xattr handler based operations will produce an -EIO result for bad inodes, and we no longer only depend on inode->i_op to be set to bad_inode_ops. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
committed by
Al Viro
parent
d0a5b995a3
commit
5f6e59ae82
@@ -58,8 +58,11 @@ xattr_resolve_name(struct inode *inode, const char **name)
|
||||
const struct xattr_handler **handlers = inode->i_sb->s_xattr;
|
||||
const struct xattr_handler *handler;
|
||||
|
||||
if (!(inode->i_opflags & IOP_XATTR))
|
||||
if (!(inode->i_opflags & IOP_XATTR)) {
|
||||
if (unlikely(is_bad_inode(inode)))
|
||||
return ERR_PTR(-EIO);
|
||||
return ERR_PTR(-EOPNOTSUPP);
|
||||
}
|
||||
for_each_xattr_handler(handlers, handler) {
|
||||
const char *n;
|
||||
|
||||
@@ -168,6 +171,9 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name,
|
||||
}
|
||||
} else if (issec) {
|
||||
const char *suffix = name + XATTR_SECURITY_PREFIX_LEN;
|
||||
|
||||
if (unlikely(is_bad_inode(inode)))
|
||||
return -EIO;
|
||||
error = security_inode_setsecurity(inode, suffix, value,
|
||||
size, flags);
|
||||
if (!error)
|
||||
|
Reference in New Issue
Block a user