ich777/linux_media
1
0
Fork 0
mirror of https://github.com/tbsdtv/linux_media.git synced 2025-07-23 12:43:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

atm: idt77252: fix null-ptr-dereference

Browse Source 
this one is similar to the phy_data allocation fix in uPD98402, the
driver allocate the idt77105_priv and store to dev_data but later
dereference using dev->dev_data, which will cause null-ptr-dereference.

fix this issue by changing dev_data to phy_data so that PRIV(dev) can
work correctly.

Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Tong Zhang
2021-03-07 22:25:30 -05:00
committed by David S. Miller
parent 3153724fc0
commit 4416e98594
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/atm/idt77105.c
View File

@@ -262,7 +262,7 @@ static int idt77105_start(struct atm_dev *dev)
{ {
unsigned long flags; unsigned long flags;
if (!(dev->dev_data = kmalloc(sizeof(struct idt77105_priv),GFP_KERNEL))) if (!(dev->phy_data = kmalloc(sizeof(struct idt77105_priv),GFP_KERNEL)))
return -ENOMEM; return -ENOMEM;
PRIV(dev)->dev = dev; PRIV(dev)->dev = dev;
spin_lock_irqsave(&idt77105_priv_lock, flags); spin_lock_irqsave(&idt77105_priv_lock, flags);
@@ -337,7 +337,7 @@ static int idt77105_stop(struct atm_dev *dev)
else else
idt77105_all = walk->next; idt77105_all = walk->next;
dev->phy = NULL; dev->phy = NULL;
dev->dev_data = NULL; dev->phy_data = NULL;
kfree(walk); kfree(walk);
break; break;
} }