mirror of
https://github.com/tbsdtv/linux_media.git
synced 2025-07-23 20:51:03 +02:00
[CRYPTO]: Kill unnecessary strncpy from tcrypt
It seems that bad code tends to get copied (see test_cipher_speed). So let's kill this idiom before it spreads any further. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
ef2736fc74
commit
3cc3816f93
@@ -266,16 +266,16 @@ static void test_cipher(char *algo, int mode, int enc,
|
|||||||
char *key;
|
char *key;
|
||||||
struct cipher_testvec *cipher_tv;
|
struct cipher_testvec *cipher_tv;
|
||||||
struct scatterlist sg[8];
|
struct scatterlist sg[8];
|
||||||
char e[11], m[4];
|
const char *e, *m;
|
||||||
|
|
||||||
if (enc == ENCRYPT)
|
if (enc == ENCRYPT)
|
||||||
strncpy(e, "encryption", 11);
|
e = "encryption";
|
||||||
else
|
else
|
||||||
strncpy(e, "decryption", 11);
|
e = "decryption";
|
||||||
if (mode == MODE_ECB)
|
if (mode == MODE_ECB)
|
||||||
strncpy(m, "ECB", 4);
|
m = "ECB";
|
||||||
else
|
else
|
||||||
strncpy(m, "CBC", 4);
|
m = "CBC";
|
||||||
|
|
||||||
printk("\ntesting %s %s %s\n", algo, m, e);
|
printk("\ntesting %s %s %s\n", algo, m, e);
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user