mirror of
https://github.com/tbsdtv/linux_media.git
synced 2025-07-23 20:51:03 +02:00
net: bonding: fix error return code of bond_neigh_init()
When slave is NULL or slave_ops->ndo_neigh_setup is NULL, no error
return code of bond_neigh_init() is assigned.
To fix this bug, ret is assigned with -EINVAL in these cases.
Fixes: 9e99bfefdb
("bonding: fix bond_neigh_init()")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
29d98f54a4
commit
2055a99da8
@@ -3978,11 +3978,15 @@ static int bond_neigh_init(struct neighbour *n)
|
|||||||
|
|
||||||
rcu_read_lock();
|
rcu_read_lock();
|
||||||
slave = bond_first_slave_rcu(bond);
|
slave = bond_first_slave_rcu(bond);
|
||||||
if (!slave)
|
if (!slave) {
|
||||||
|
ret = -EINVAL;
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
slave_ops = slave->dev->netdev_ops;
|
slave_ops = slave->dev->netdev_ops;
|
||||||
if (!slave_ops->ndo_neigh_setup)
|
if (!slave_ops->ndo_neigh_setup) {
|
||||||
|
ret = -EINVAL;
|
||||||
goto out;
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
/* TODO: find another way [1] to implement this.
|
/* TODO: find another way [1] to implement this.
|
||||||
* Passing a zeroed structure is fragile,
|
* Passing a zeroed structure is fragile,
|
||||||
|
Reference in New Issue
Block a user