ich777/linux_media
1
0
Fork 0
mirror of https://github.com/tbsdtv/linux_media.git synced 2025-07-23 12:43:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

scsi: acornscsi: Use standard defines

Browse Source 
Use midlayer-defined values and drop the non-existing QUEUE_FULL case; we
are checking the SCSI messages in the switch statement, and QUEUE_FULL is a
SCSI status hence it can never occur here.

Link: https://lore.kernel.org/r/20210113090500.129644-11-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hannes Reinecke
2021-01-13 10:04:35 +01:00
committed by Martin K. Petersen
parent eb74b9322b
commit 0eb198d2c3
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/scsi/arm/acornscsi.c
View File

@@ -144,12 +144,6 @@
#define VER_MINOR 0 #define VER_MINOR 0
#define VER_PATCH 6 #define VER_PATCH 6
#ifndef ABORT_TAG
#define ABORT_TAG 0xd
#else
#error "Yippee! ABORT TAG is now defined! Remove this error!"
#endif
#ifdef USE_DMAC #ifdef USE_DMAC
/* /*
* DMAC setup parameters * DMAC setup parameters
@@ -1490,8 +1484,8 @@ void acornscsi_message(AS_Host *host)
} }
switch (message[0]) { switch (message[0]) {
case ABORT: case ABORT_TASK_SET:
case ABORT_TAG: case ABORT_TASK:
case COMMAND_COMPLETE: case COMMAND_COMPLETE:
if (host->scsi.phase != PHASE_STATUSIN) { if (host->scsi.phase != PHASE_STATUSIN) {
printk(KERN_ERR "scsi%d.%c: command complete following non-status in phase?\n", printk(KERN_ERR "scsi%d.%c: command complete following non-status in phase?\n",
@@ -1596,10 +1590,6 @@ void acornscsi_message(AS_Host *host)
} }
break; break;
case QUEUE_FULL:
/* TODO: target queue is full */
break;
case SIMPLE_QUEUE_TAG: case SIMPLE_QUEUE_TAG:
/* tag queue reconnect... message[1] = queue tag. Print something to indicate something happened! */ /* tag queue reconnect... message[1] = queue tag. Print something to indicate something happened! */
printk("scsi%d.%c: reconnect queue tag %02X\n", printk("scsi%d.%c: reconnect queue tag %02X\n",